Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DEV-1598: Fix for empty toname in control tag #3161

Merged
merged 14 commits into from
Nov 1, 2022

Conversation

robot-ci-heartex
Copy link
Collaborator

Hi @juliosgarbi!

This PR was created in response to a PRs in upstream repo:

@github-actions github-actions bot added the fix label Oct 28, 2022
@swarmia
Copy link

swarmia bot commented Oct 28, 2022

✅  Linked to Bug DEV-1598 · Editable TextArea fail on input
➡️  Part of Epic DEV-3239 · Customer Issues - Q4 Sprint 1

@juliosgarbi juliosgarbi reopened this Oct 28, 2022
@juliosgarbi juliosgarbi reopened this Oct 28, 2022
@makseq makseq marked this pull request as ready for review October 31, 2022 15:52
@robot-ci-heartex robot-ci-heartex enabled auto-merge (squash) November 1, 2022 20:22
@makseq makseq disabled auto-merge November 1, 2022 21:35
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Base: 77.29% // Head: 77.08% // Decreases project coverage by -0.21% ⚠️

Coverage data is based on head (5a8be82) compared to base (97398eb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3161      +/-   ##
===========================================
- Coverage    77.29%   77.08%   -0.22%     
===========================================
  Files          147      147              
  Lines        10823    10825       +2     
===========================================
- Hits          8366     8344      -22     
- Misses        2457     2481      +24     
Impacted Files Coverage Δ
...el_studio/label_studio/data_manager/serializers.py 89.32% <0.00%> (-2.92%) ⬇️
label_studio/label_studio/core/utils/common.py 81.25% <0.00%> (-2.09%) ⬇️
label_studio/label_studio/data_manager/managers.py 78.08% <0.00%> (-1.41%) ⬇️
..._studio/label_studio/labels_manager/serializers.py 96.25% <0.00%> (-1.25%) ⬇️
label_studio/label_studio/core/middleware.py 89.24% <0.00%> (-1.08%) ⬇️
label_studio/label_studio/tasks/serializers.py 83.64% <0.00%> (-0.54%) ⬇️
label_studio/label_studio/projects/models.py 82.75% <0.00%> (-0.11%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@makseq makseq merged commit bfbc880 into develop Nov 1, 2022
@makseq makseq deleted the fb-dev-1598/empty-toname branch November 1, 2022 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants