fix: Issue 3220 Update Django version for CVEs #3238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh looks like it failed because the Github action checkout is broken for forks? I can open another one without forking if that works |
wesleylima
approved these changes
Nov 15, 2022
wesleylima
pushed a commit
that referenced
this pull request
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
Fixes issue #3220 by bumping to
Django==3.2.16that fixed two CVEs related to Django.I followed what was done here when it was last updated to
3.2.14Dev notes
I only have a Mac so I tested locally with
sqliteand one of the tests (see below) failed for thedevelopbase branch when I pulled from the most recent -- yet I don't see a failed build on GitHub 馃. All other tests passed.Therefor I'm not sure if my test setup was correct. I tried following both
READMEto install and then copied how GItHub workflow script setup the testing env to no avail. This may not be an issue though.