Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DEV-3764: Fix CSV export download with non-existing columns #3263

Merged
merged 6 commits into from
Nov 23, 2022

Conversation

KonstantinKorotaev
Copy link
Contributor

No description provided.

@swarmia
Copy link

swarmia bot commented Nov 17, 2022

@github-actions github-actions bot added the fix label Nov 17, 2022
@nikitabelonogov nikitabelonogov marked this pull request as ready for review November 17, 2022 16:46
@niklub niklub self-requested a review November 23, 2022 19:56
Copy link
Collaborator

@niklub niklub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it green

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Base: 77.80% // Head: 77.08% // Decreases project coverage by -0.71% ⚠️

Coverage data is based on head (75a09ad) compared to base (17b40da).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3263      +/-   ##
===========================================
- Coverage    77.80%   77.08%   -0.72%     
===========================================
  Files          137      148      +11     
  Lines         9951    10930     +979     
===========================================
+ Hits          7742     8425     +683     
- Misses        2209     2505     +296     
Impacted Files Coverage Δ
label_studio/label_studio/core/mixins.py 0.00% <0.00%> (-100.00%) ⬇️
label_studio/label_studio/users/mixins.py 75.00% <0.00%> (-12.50%) ⬇️
...bel_studio/label_studio/organizations/functions.py 66.66% <0.00%> (-10.26%) ⬇️
...tudio/label_studio/projects/functions/next_task.py 75.97% <0.00%> (-8.59%) ⬇️
label_studio/label_studio/ml/api.py 83.69% <0.00%> (-6.85%) ⬇️
...l_studio/label_studio/core/templatetags/filters.py 48.75% <0.00%> (-6.20%) ⬇️
label_studio/label_studio/core/redis.py 38.38% <0.00%> (-5.69%) ⬇️
..._studio/label_studio/core/settings/label_studio.py 94.59% <0.00%> (-5.41%) ⬇️
label_studio/label_studio/organizations/api.py 79.04% <0.00%> (-5.33%) ⬇️
.../label_studio/data_manager/actions/experimental.py 14.79% <0.00%> (-4.72%) ⬇️
... and 79 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@niklub niklub merged commit 9df005b into develop Nov 23, 2022
@github-actions github-actions bot deleted the fb-DEV-3764 branch November 23, 2022 23:15
shayantabatabaee pushed a commit to shayantabatabaee/label-studio that referenced this pull request Sep 19, 2023
…anSignal#3263)

* fix: DEV-3764: Fix CSV export download with non-existing columns

* Add test

* Fix dependancy link

* Update requirements.txt

* Fix tests

* Update data_export.tavern.yml

Co-authored-by: Nikita Belonogov <nikita.belonogov@heartex.com>
Co-authored-by: niklub <lubimov.nicolas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants