Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Music page doesnt render correctly on a tablet (Pinetab2) #43

Closed
piggz opened this issue Jan 13, 2024 · 9 comments · Fixed by #44
Closed

Music page doesnt render correctly on a tablet (Pinetab2) #43

piggz opened this issue Jan 13, 2024 · 9 comments · Fixed by #44

Comments

@piggz
Copy link

piggz commented Jan 13, 2024

On my pinetab2, i can navigate the main UI, through to Music and get the list of latest/albums.

When clicking an Album, the next page loads, however its not possible to select any tracks to play.

In portrait, the album art takes the full page and nothing else is visible.

In landscape, the album art takes the full screen again, but i can see some track lengths along the right side, but nothing else.

@HenkKalkwater
Copy link
Member

Could you perhaps send some screenshots? I do not have a tablet and it looked fine in landscape mode on my phone.

@piggz
Copy link
Author

piggz commented Jan 15, 2024

photo_2024-01-15_20-22-04
photo_2024-01-15_20-21-58

Sorry theyre not screenshots ... the pt2 takes empty screenshots :)

@HenkKalkwater
Copy link
Member

Hey, I tried fixing it but I have no tablet to try it out on. Could you verify that this fix works?
harbour-sailfin-0.5.0-1.aarch64.rpm.gz (you need to ungzip it, because GitHub does not allow me to upload .rpm files). Alternatively, you can apply the commit from the linked pull request.

@piggz
Copy link
Author

piggz commented Jan 17, 2024

Hi, thanks for trying, but I see no change :/

@piggz
Copy link
Author

piggz commented May 3, 2024

Hi, I took a look at this ... the issue seems to be here
Loader {
id: wideAlbumCover
visible: _twoColumns
Layout.minimumWidth: 1000 / Theme.pixelRatio
Layout.fillHeight: true
source: visible
? "../../components/music/WideAlbumCover.qml" : ""
onLoaded: bindAlbum(item)
}
in pages/itemdetails/MusicAlbumPage.qml

Setting the value from 1000 to 500 works much better here, in landscape mode on the pt2. Maybe some value that is proportional to the screen could be found, and not hard coded?

@piggz
Copy link
Author

piggz commented May 3, 2024

In portrait mode, it still looks bad, but its this are that the issue

@HenkKalkwater
Copy link
Member

Alright, I finally got Sailfin working in the emulator. It turned out that I needed to install the qt5-qtmultimedia-plugin-mediaservice-gstmediacapture and qt5-qtmultimedia-plugin-mediaservice-gstmediaplayer packages on the emulator. Now I can properly test tablet screen sizes.

I've dropped the whole <constant> * Theme.pixelRatio-approach1, because the values seemed quite arbitrary and I was entering random numbers. I'm now doing it on multiples of Theme.itemSizeHuge, which is easier to reason about. I took the liberty to make some simple other layout changes as well to improve the experience on tablet screens.

The screen now should look like this:
afbeelding

If you'd like to test, feel free to compile #44 yourself or install the following RPM, which is a compile of commit 60b9133:
harbour-sailfin-0.5.0-1.aarch64.rpm.gz

Footnotes

  1. Which I was doing wrong by the way, because I should multiply by the Theme.pixelRatio, not divide.

@piggz
Copy link
Author

piggz commented Jun 3, 2024

Oh, i totally missed that you'd fixed this, looking forward to trying!

@piggz
Copy link
Author

piggz commented Jun 3, 2024

Have tested on the PT2 with landscape and portrait, and its working a lot better, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants