Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor various CardArt components to use inheritance #55

Closed
beheh opened this issue Mar 9, 2016 · 1 comment
Closed

Refactor various CardArt components to use inheritance #55

beheh opened this issue Mar 9, 2016 · 1 comment
Labels
cleanup

Comments

@beheh
Copy link
Member

beheh commented Mar 9, 2016

Using TypeScript we can actually make the card art components extend from the base component. This would also mean we have a decent place for the texture lookup, which is currently in InPlayCardArt (it can't go into CardArt because of the dimensions wrapping).

There's a bit too much prop passing going on right now in those components.
@beheh beheh added the cleanup label Oct 11, 2016
@beheh beheh closed this as completed Aug 21, 2017
@beheh
Copy link
Member Author

beheh commented Aug 21, 2017

No longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup
Milestone
No milestone
Development

No branches or pull requests
2 participants
@beheh and others