Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing return statements in DataHandler.cs? #14

Closed
sebastientromp opened this issue Dec 2, 2015 · 1 comment
Closed

Missing return statements in DataHandler.cs? #14

sebastientromp opened this issue Dec 2, 2015 · 1 comment
Assignees
@azeier
Labels
csharp

Comments

@sebastientromp
Copy link

Hey,

Looking through the code in DataHandler.cs, and two of the match.Success cases don't have a return statement. Is this intentional?

No idea if this could cause a bug or if this is intentional, just thought I would raise the point in case it might help.

Cheers,
Seb
@azeier azeier closed this as completed in 5b3b5a6 Dec 3, 2015
@azeier
Copy link
Member

azeier commented Dec 3, 2015

Shouldn't have any effect aside from maybe a very minor impact on performance.

Indeed not intentional though - fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azeier azeier

Labels
csharp
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jleclanche @azeier @sebastientromp