Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated Game entity has attribute "timestamp" instead of "ts" #18

Closed
sebastientromp opened this issue Dec 7, 2015 · 0 comments
Closed
Assignees
Labels

Comments

@sebastientromp
Copy link

Looking at the c# code, it looks like the Game entity generate an attribute named timestamp in the XML, like

public class Game
{
    [XmlAttribute("timestamp")]
    public string TimeStamp { get; set; }

    [XmlAttribute("type")]
    public int Type { get; set; }

    [XmlElement("Action", typeof(Action))]
    [XmlElement("Choices", typeof(Choices))]
    [XmlElement("FullEntity", typeof(FullEntity))]
    [XmlElement("GameEntity", typeof(GameEntity))]
    [XmlElement("ShowEntity", typeof(ShowEntity))]
    [XmlElement("HideEntity", typeof(HideEntity))]
    [XmlElement("Options", typeof(Options))]
    [XmlElement("Player", typeof(PlayerEntity))]
    [XmlElement("SendChoices", typeof(SendChoices))]
    [XmlElement("SendOption", typeof(SendOption))]
    [XmlElement("TagChange", typeof(TagChange))]
    [XmlElement("MetaData", typeof(MetaData))]
    [XmlElement("ChosenEntities", typeof(ChosenEntities))]
    public List<GameData> Data { get; set; }
}

According to the spec, the attribute should be name ts

Edit: GameData entities are fine, only Game entity is affected

@sebastientromp sebastientromp changed the title Generate ReplayData entities have attribute "timestamp" instead of "ts" Generated Game entity has attribute "timestamp" instead of "ts" Dec 7, 2015
@azeier azeier closed this as completed in 82dc7d3 Dec 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants