Convert Client::_fetch_target's lookup fn into a method #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Boop-ing for rebase. (Looks good though. Will do a final check at the end.) |
|
Rebased as well. |
|
Boop-ing for a review :) |
|
Yup, I’m on vacation so it might take a few :)
Von meinem iPhone gesendet
… Am 23.07.2018 um 16:22 schrieb Erick Tryzelaar ***@***.***>:
Boop-ing for a review :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
No problem! Thanks so much!
…On Mon, Jul 23, 2018 at 2:53 PM heartsucker ***@***.***> wrote:
Yup, I’m on vacation so it might take a few :)
Von meinem iPhone gesendet
> Am 23.07.2018 um 16:22 schrieb Erick Tryzelaar ***@***.***
>:
>
> Boop-ing for a review :)
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub, or mute the thread.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#139 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFK55WucMPzDGFg2BCCUJedZj2FsoQcks5uJkXDgaJpZM4VToXT>
.
|
|
Poking for rebase. |
This is a minor simplification of `Client::_fetch_target` to factor out the interior lookup function in order to cut out on a number of variables being passed in as arguments.
|
It took a rather long while, but I finally rebased this patch! |
heartsucker
approved these changes
Dec 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor simplification of
Client::_fetch_targettofactor out the interior lookup function in order to cut
out on a number of variables being passed in as arguments.