Drop MetadataVersion::Hash, resolve #254 #262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickt
requested changes
Jan 2, 2020
There was a problem hiding this comment.
Thanks for this! Other than my in-line comment, can you also:
- check if python-tuf is fetching delegations by version number, just to be safe?
- add a test to make sure we are fetching delegations by version number. Simplest would be to extend src/client.rs's
test_versioned_initwith a delegation. You can find how to make a delegation by looking at tests/integration.rs.
| @@ -871,12 +871,6 @@ where | |||
| Err(e) => return (delegation.terminating(), Err(e)), | |||
| }; | |||
|
|
|||
| let version = if self.tuf.root().consistent_snapshot() { | |||
| MetadataVersion::Hash(value.clone()) | |||
There was a problem hiding this comment.
I think we want this conditional, just returning MetadataVersion::Number(role_meta.version()) when consistent snapshot is enabled.
|
I addressed the inline comment, I'll handle the test extension in a separate commit. I still need to understand a few more things. Thanks! |
erickt
approved these changes
Oct 23, 2020
|
This was incorporated into another PR that has since landed. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.