Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Id's conflicts #17

Closed
Timopheym opened this issue Jun 9, 2014 · 2 comments
Closed

Id's conflicts #17

Timopheym opened this issue Jun 9, 2014 · 2 comments

Comments

@Timopheym
Copy link

Here D4 created svg element with chart id.
https://github.com/heavysixer/d4/blob/master/src/base.js#L354
If you want to have several charts - you will get id conflicts.
May be it would be better to remove id form there?

@heavysixer
Copy link
Owner

@Timopheym yes this is a good idea. Can you make this change and a test and send me a pull-request?

@heavysixer
Copy link
Owner

@Timopheym actually, why does this example not produce the same error? http://visible.io/charts/column/small-multiples.html

Do you have a fiddle document that you can show with this error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants