Skip to content
This repository has been archived by the owner on Apr 23, 2024. It is now read-only.

Planned Additions/Fixes for 0.1.0 #3

Closed
12 of 13 tasks
petabyt opened this issue Feb 9, 2019 · 54 comments
Closed
12 of 13 tasks

Planned Additions/Fixes for 0.1.0 #3

petabyt opened this issue Feb 9, 2019 · 54 comments
Labels
good first issue Good for newcomers

Comments

@petabyt
Copy link
Member

petabyt commented Feb 9, 2019 •
edited
Loading

  • Add a few more translations
  • Add themes
  • Finish search function
  • Reposition the Random button
  • Add verse of the day
  • Add a mobile view to the website (not really related to the app)
  • Speed improvement
  • Bookmarks
  • Redesign the sidebar
  • Add swiping to the sidebar
  • Make link/button to go to verse in VOTD
  • Verse popup shows when trying to close the sidebar
  • Verse popup shows when switching chapters/books
@petabyt petabyt added enhancement New feature or request good first issue Good for newcomers and removed enhancement New feature or request good first issue Good for newcomers labels Feb 9, 2019
@MasterOfTheTiger
Copy link
Contributor

Can you add instructions in the README for development instructions? Like setting it up in Android Studio.

@petabyt
Copy link
Member Author

petabyt commented Feb 10, 2019

I was thinking about doing something like that in the wiki page. https://github.com/heb12/heb12-mobile/wiki

@MasterOfTheTiger
Copy link
Contributor

@pufflegamerz Maybe, or maybe a development.md or something. We need something in a better place than the wiki, because it needs to be downloaded when someone clones the repo.

@MasterOfTheTiger
Copy link
Contributor

Either way, it should be added.

@petabyt
Copy link
Member Author

petabyt commented Feb 13, 2019 •
edited
Loading

I think the app is ready to be released. I've fixed most of the major problems. Tell me if you find any bugs.

@MasterOfTheTiger
Copy link
Contributor

Sorry. But I think we need more translations for more people to accept it. Don't you think? Maybe we should release the app as version 0.1.0 (following semantic versioning) now.

@petabyt
Copy link
Member Author

petabyt commented Feb 13, 2019

I was hesitant about adding more translations, because it might make the app slower, and it already takes a while to load. What translations should I add? I don't see myself using more than 2.

@MasterOfTheTiger
Copy link
Contributor

Okay. We need a better solution then. Can we load them into RAM only after they are selected?

@petabyt
Copy link
Member Author

petabyt commented Feb 14, 2019

I just figured out a way to load the bible files only when a new translation is selected. I tried to do it before, and it didn't work. I guess I did something different and now it functional.

@MasterOfTheTiger
Copy link
Contributor

MasterOfTheTiger commented Feb 15, 2019 •
edited by petabyt
Loading

Another few things which need to be done:

  • Fix KJV 2000 verse selection (I can't get it to select the right verse for some reason)
  • Support verse selection in NET
  • Fix "next" and "previous" for KJV 2000 when next or previous is different book.

You should be able to reproduce all those issues. I found them in the 13th's version of the app. So you may have fixed some.

Here are some more things which should probably be done:

  • Font size configuration (in addition to fixing the font size with the NET translation)

  • Change version number in info screen from 1.0 to 0.1.0

  • Improve code and documentation for other developers and contributors.

@MasterOfTheTiger
Copy link
Contributor

Not sure you can do much about this, but it would be pretty useful to be able to use the up and down arrow keys on an Android hardware keyboard to move up and down on the Bible passage.

@MasterOfTheTiger
Copy link
Contributor

Another thing we should do before the new version is released is the ability to easily compare versions in the popup. You can decide the best way to impliment it.

@petabyt
Copy link
Member Author

petabyt commented Feb 15, 2019

Ok. I'll look into the issues. About the android keyboard part, are you talking about an external keyboard?

@MasterOfTheTiger
Copy link
Contributor

Yes I am. It isn't a big deal, but I was trying to scroll down with the arrow keys and it didn't works. Kinda odd for a web based app when you think about it.

Another question is, how hard would this app be to translate? Do you use external Android strings?

@MasterOfTheTiger
Copy link
Contributor

Another thing is, could you possibly be more descriptive in your commit messages? That's kinda important for both other contributors and for looking back at code later.

@MasterOfTheTiger
Copy link
Contributor

Another bug:

  • When clicking previous at chapter 1 of James, it goes to Hebrews 5 instead of 13 on the ASV translation.

@MasterOfTheTiger
Copy link
Contributor

Ouch. The NET seems to be entirely broken. It says "undefined" where the Scripture should be.

@petabyt
Copy link
Member Author

petabyt commented Feb 16, 2019

Press next, it should work.

@petabyt
Copy link
Member Author

petabyt commented Feb 16, 2019

I attached a keyboard to my phone and the scrolling with arrow keys worked.

@MasterOfTheTiger
Copy link
Contributor

Oh, I understand now. It kinda works like TAB by selecting all of the verse numbers. The NET still doesn't work, and the previous button should be fixed. It is entirely inconsistent.

@petabyt
Copy link
Member Author

petabyt commented Feb 16, 2019

I fixed some of the issues. The NET should work now.

@petabyt
Copy link
Member Author

petabyt commented Feb 18, 2019

I kinda want to make a dedicated website for Heb12 Mobile, because the one we have right now just looks a little plain.

@MasterOfTheTiger
Copy link
Contributor

Okay. You can do that. Put it in a gh-pages branch

@petabyt
Copy link
Member Author

petabyt commented Feb 20, 2019

I put it in the docs directory. https://heb12.ml/heb12-mobile/ Do you think it looks good? I will definitely change it a lot later on.

@MasterOfTheTiger
Copy link
Contributor

Awesome! I like it.

By the way, how can I help with Heb12 Mobile? What do you need me to do?

@petabyt
Copy link
Member Author

petabyt commented Feb 21, 2019

Thanks! The side menu definitely needs some touching up, and the online NET translation css needs some work. The verse of the day comes from the Bible Labs API. http://labs.bible.org/api/?passage=votd

@MasterOfTheTiger
Copy link
Contributor

@pufflegamerz If I have a chance I will work on it. We need to do as much work as we can in the next week. Hopefully we can publish it on Google Play within a week (at least some kind of beta). Then later F-Droid as well.

@petabyt
Copy link
Member Author

petabyt commented Feb 21, 2019

I'm pretty sure there is a $25 fee to get a developer account on Google Play. The Amazon App store is free though.

@MasterOfTheTiger
Copy link
Contributor

Yeah. I know. I might see about paying it if I can.

I'll see about putting it in the Amazon app store. F-Driod is also free but can be cumbersome.

@petabyt
Copy link
Member Author

petabyt commented Feb 21, 2019 •
edited
Loading

You don't have to. I have an Amazon Developer account where I published a couple of apps a couple of years ago.

@MasterOfTheTiger
Copy link
Contributor

@pufflegamerz. Okay. But to be honest, I would like to have access to it somehow. Because I am the owner of Heb12. Of course you are the lead (and only) developer of Heb12 Mobile, so I am fine with you publishing it. Once we agree on the release of 0.1.0 you can publish it.

@petabyt
Copy link
Member Author

petabyt commented Feb 25, 2019 •
edited
Loading

Could I make a folder in the heb12.github.up repository named Mobile so I can put the website in it? The code and website probably shouldn't be in the same repository.

@MasterOfTheTiger
Copy link
Contributor

Yes. That is totally fine.

@MasterOfTheTiger
Copy link
Contributor

@pufflegamerz Verse selection in NET is very broken.

@petabyt
Copy link
Member Author

petabyt commented Mar 9, 2019 via email

@petabyt
Copy link
Member Author

petabyt commented Mar 9, 2019 via email

@petabyt
Copy link
Member Author

petabyt commented Mar 9, 2019 via email

@petabyt
Copy link
Member Author

petabyt commented Mar 9, 2019 via email

@MasterOfTheTiger
Copy link
Contributor

@pufflegamerz In addition, normal verse selection doent seem to be working consistently.

@petabyt
Copy link
Member Author

petabyt commented Mar 9, 2019 •
edited
Loading

It should work in the latest apk.

@petabyt
Copy link
Member Author

petabyt commented Mar 9, 2019

For some reason, I uploaded an older apk file. It should work now.

@MasterOfTheTiger
Copy link
Contributor

MasterOfTheTiger commented Mar 10, 2019 •
edited
Loading

The font size still does not work. It reads "NaN". I am able to change the Heb12 config file to a valid number to change this though.

Plus. Shouldn't the config file be in the Android assigned location for heb12? (Android/data/io.github.heb12.heb12mobile or something like that).that should fix the storage problem.

@petabyt
Copy link
Member Author

petabyt commented Mar 10, 2019 via email

@MasterOfTheTiger
Copy link
Contributor

5.0. But shouldn't that be irrelevent? Try deleting the app and the configuration file and try again.

@MasterOfTheTiger
Copy link
Contributor

By the way Android 4.x doesn't work. It installs, but the app gets stuck at the loading part.

@petabyt
Copy link
Member Author

petabyt commented Mar 11, 2019 via email •
edited
Loading

@petabyt
Copy link
Member Author

petabyt commented Mar 11, 2019 via email

petabyt pushed a commit that referenced this issue Mar 25, 2019
Fix major bug I didn't notice
9a2ce26 
#3
@MasterOfTheTiger
Copy link
Contributor

You need to make sure that it opens the last Bible translation used (if you haven't done that already).

@petabyt
Copy link
Member Author

petabyt commented Apr 22, 2019

I've tried making that work for hours, but I was never able to fix it.

@MasterOfTheTiger
Copy link
Contributor

Odd. Shouldn't it work the same as storing previously opened books and chapters? Either way, that is a pretty big deal as it is expected to work that way...

@petabyt
Copy link
Member Author

petabyt commented Apr 23, 2019

It gets stored in the config file, then when the app opens It goes to the default. I'll try my best to fix it.

@MasterOfTheTiger
Copy link
Contributor

Okay. Thanks! I am going to download Android Studio myself right now and see if I can help with something later.

@MasterOfTheTiger
Copy link
Contributor

Okay. I am closing this now since 0.1.0 is released. Open new issues for individual features from now on I guess.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MasterOfTheTiger @petabyt