Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an event flag for torah readings #5

Open
chabad360 opened this issue Jun 7, 2023 · 1 comment · May be fixed by #6
Open

Add an event flag for torah readings #5

chabad360 opened this issue Jun 7, 2023 · 1 comment · May be fixed by #6

Comments

@chabad360
Copy link

Would it be possible to have an event flag that covers days the torah is read? As far as I can tell, there is no particular way to filter for that.

@mjradwin
Copy link
Member

mjradwin commented Jun 7, 2023

This is a good suggestion. It's not terribly difficult, but it is a bit tedious to implement.

Do you want to try to implement it and send a pull request?

Beyond adding a new constant to the HolidayFlags in event/event.go, most (all?) of the work will be editing hebcal/holidays.go

@chabad360 chabad360 linked a pull request Jun 8, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants