Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

City problem after New York #30

Closed
mjradwin opened this issue Jul 2, 2013 · 2 comments
Closed

City problem after New York #30

mjradwin opened this issue Jul 2, 2013 · 2 comments

Comments

@mjradwin
Copy link
Member

mjradwin commented Jul 2, 2013

Submitted by ted on 2011-08-02 08:08:58

hebcal version 3.9.1:
hebcal doesn't recognize cities after "New York" in the for loop in set_default_city, even with
--with-default-city="Winston-Salem NC" and having put "Winston-Salem NC" in cities.h.
This is true no matter whether the new city is inserted after or before "New York."

@acli
Copy link
Contributor

acli commented May 24, 2016

I have confirmed this problem in hebcal 4.6. This is happening because localize_to_city in start.c is converting all non-alphas to spaces in the city specified by --with-default-city, but “Winston-Salem NC” has a hyphen, so if this is how the city is entered into cities.h the comparison will never succeed.

@mjradwin
Copy link
Member Author

Closing this as Hebcal 5 has been rewritten in Golang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants