Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content Entities that are "Revisionable / have Published statuses for workflow" extend from - 'EditorialContentEntityBase' #4084

Closed
dylanlawrence opened this issue Jun 10, 2019 · 0 comments

Comments

@dylanlawrence
Copy link

Content Entities revisioning and published statuses - 'EditorialContentEntityBase'

[ generate:entity:content ] When generating a content entity and selecting revisionable it would be better for it to comply with the 'EditorialContentEntityBase' which apparently is being used to has a consistent base for published statuses.

Problem/Motivation

The change happened in 8.4 and is currently used in the common entities listed. ex: taxonomy_term code

Details:

  • The workflow for currently generated revisionable content entities warns :

[custom entity] entities do not support publishing statuses. For example, even after transitioning from a published workflow state to an unpublished workflow state they will still be visible to site visitors.

To reproduce

Generate a custom entity and add a workflow to it.

  • Drupal version 8.4+.
  • Drupal Console version 1.8.0

Solution

Extend now content entities from EditorialContentEntityBase rather than RevisionableContentEntityBase for revisionable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants