Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Game::on_close_request #11

Closed
hecrj opened this issue Apr 25, 2019 · 0 comments · Fixed by #14
Closed

Implement Game::on_close_request #11

hecrj opened this issue Apr 25, 2019 · 0 comments · Fixed by #14
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@hecrj
Copy link
Owner

hecrj commented Apr 25, 2019

We should implement a Game::on_close_request and use its return value here to decide whether we should end the game loop or not.
@hecrj hecrj added feature New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Apr 25, 2019
@jalbert-dev jalbert-dev mentioned this issue Apr 25, 2019
Merged
@hecrj hecrj closed this as completed in #14 Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Game::on_close_request jalbert-dev/coffee
1 participant
@hecrj