Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the call to cassandra.describe_keyspace fault tolerant #11

Closed
rantav opened this issue Mar 30, 2010 · 6 comments
Closed

Make the call to cassandra.describe_keyspace fault tolerant #11

rantav opened this issue Mar 30, 2010 · 6 comments

Comments

@rantav
Copy link
Collaborator

rantav commented Mar 30, 2010

The call to cassandra.describe_keyspace is at CassandraClientImpl.getKeyspace()
This is a "meta" call, which is invoked once per keyspace before any other operation on that keyspace is performed.
This call, if unsuccessful, will not use the failover policy used by all other read/write operations.
It should.

@hz
Copy link

hz commented Apr 9, 2010

I don't know how to merge my modifications to my fork. I pasted my solution into gist.github.com/hz, 360995 is a interface, 360996 is request featured with failover and pooling. 360997 is the wrapper for thrift api. 30999 is the revised keyspaceimpl. you do some tricks on getColumn. I can not solve it.
After the clean wrapper of thrift api, this issue will be solved.

@rantav
Copy link
Collaborator Author

rantav commented Apr 11, 2010

Sorry, it's pretty hard to see diffs in gists. It's preferable that you push back to your hz/hector repo so I can see diffs and send line comments, but if this isn't working for you, then email me a patch

@mgrogan
Copy link

mgrogan commented Apr 26, 2010

Any idea when this problem is likely to be resolved? Occasionally I experience a transport error which causes the call to getKeyspace to fail. When this happens Hector does not recover and all subsequent calls to getKeyspace fail.

@rantav
Copy link
Collaborator Author

rantav commented Apr 26, 2010

I guess I was just waiting for someone to need this bad enough to implement that...
If you're not into hacking that I'll try to find some time for it this week

@Mishail
Copy link
Contributor

Mishail commented May 21, 2010

Well, http://github.com/Mishail/hector/commit/a8c9a0accd49d1e8f76ad15d8250f608f8a9d755

Though I'm not sure that all is done properly... The code is mostly borrowed from CassandraClusterImpl. And all unit-test are passed (except one, which I marked as @ignore and specified the reason)

@rantav
Copy link
Collaborator Author

rantav commented Jun 14, 2010

fixed on master e5f29a4..1bf8ab5 master -> master

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants