Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve iteration order on getRangeSlice #17

Closed
killerwhile opened this issue Apr 2, 2010 · 6 comments
Closed

Preserve iteration order on getRangeSlice #17

killerwhile opened this issue Apr 2, 2010 · 6 comments
Labels

Comments

@killerwhile
Copy link
Contributor

In KeyspaceImpl.getRangeSlice, the result is put into a HashMap, thus we loose the iteration order of the Range.

The result should be put into a LinkedHashMap

(note : remove diff)

@killerwhile
Copy link
Contributor Author

KeyspaceImpl, line 148 (I don't know how to pretty print the diff here :))

@killerwhile
Copy link
Contributor Author

I guess getSuperRangeSlice and so on have the same issue.

@rantav
Copy link
Collaborator

rantav commented Apr 4, 2010

hi, sorry for slowness I'm on vacation but I'll look into it.

@killerwhile
Copy link
Contributor Author

Don't worry. Hoping you have had great time.
I have patched the source on my side.

@rantav
Copy link
Collaborator

rantav commented Apr 8, 2010

Fixed

$ git push --all
Counting objects: 44, done.
Delta compression using up to 2 threads.
Compressing objects: 100% (18/18), done.
Writing objects: 100% (24/24), 1.95 KiB, done.
Total 24 (delta 13), reused 0 (delta 0)
To git@github.com:rantav/hector.git
1a80908..f242a26 0.5.0 -> 0.5.0
43c35f5..c5e7d84 0.5.1 -> 0.5.1
0912dd0..6d121f8 0.6.0 -> 0.6.0
4321125..c87d6d1 master -> master

@killerwhile
Copy link
Contributor Author

Thanks !

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants