Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How about add a image viewer ? #2230

Closed
yurenchen000 opened this issue Apr 1, 2022 · 3 comments
Closed

How about add a image viewer ? #2230

yurenchen000 opened this issue Apr 1, 2022 · 3 comments
Labels
type: feature Adds or requests new functionality

Comments

@yurenchen000
Copy link

yurenchen000 commented Apr 1, 2022

Is your feature request related to a problem? Please describe.

not really a problem,
just view large / many image have a better experience.

Describe the solution you'd like

embed some third-part image viewer .js
to enchance image view:
 zoom, slideshow, rotate..

Describe alternatives you've considered

I make a demo, which use this component
https://fengyuanchen.github.io/viewerjs/
 // screenshot at end of the post

pc & mobile seems works,
 but mobile button small.

I handled published & edit preview page,
 but live preview not imlement very well.

Additional context

If you wish,
I'd like to post my demo code or site here.


pc screenshot:
codimd_img_viewer_pc.png


mobile screenshot:
codimd_img_viewer_mobile.png


hedgedoc is awesome !

@yurenchen000 yurenchen000 added the type: feature Adds or requests new functionality label Apr 1, 2022
@mrdrogdrog
Copy link
Member

Hello @yurenchen000 ,

An image viewer is already planned (and included) in HedgeDoc 2. You can test it out on https://hedgedoc.dev/n/features .
We won't add it to the HedgeDoc 1 code base because it is in maintenance only mode

@ErikMichelson
Copy link
Member

As this is already included in the current development state of HedgeDoc 2, I'm going to close this issue.
If you want to request more image viewer features (like those from viewer.js), please open an issue in the frontend issue tracker.

@yurenchen000
Copy link
Author

If anyone needs it, here is the patch:

yurenchen000#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature Adds or requests new functionality
Projects
None yet
Development

No branches or pull requests

3 participants