Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make repeatable as a Token #24

Closed
hedhyw opened this issue Jun 15, 2022 · 0 comments · Fixed by #27
Closed

Make repeatable as a Token #24

hedhyw opened this issue Jun 15, 2022 · 0 comments · Fixed by #27
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@hedhyw
Copy link
Owner

hedhyw commented Jun 15, 2022

  1. Idea

    type Repeatable struct {
       Token dialect.Token
       Suffix string
    }
    
    newRepeatable(token dialect.Token) // Default Suffix is `""`.
    
    OneOrMore() // And others should return `dialect.Token`.

    WriteTo -> Token than Suffix.

  2. ClassRepetable

type ClassRepetable struct {
   dialect.ClassToken
   Repeatable
}
  1. Return ClassRepetable for all Chars.* and for Common.Raw.
@hedhyw hedhyw added the enhancement New feature or request label Jun 15, 2022
@hedhyw hedhyw added the good first issue Good for newcomers label Jun 15, 2022
This was referenced Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants