-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make rename highlighting less visible #5
Comments
This would be great - I use a very small font and the highlight makes the text unreadable. |
Do you use the latest version? I've already changed it to a black dashed border. Or is that still to much? |
I use a dark theme so it looks like this for me (the error lens isn't helping either, but that's not your fault!): I understand the problem though - in my own extension I ended up adding lots of configuration options for highlights because everybody seems to want something different. If I'm honest, the background colour works well enough for me. What is also annoying is that it's not simple to just pass straight CSS into vscode's highlights. |
I see. I think I will add some options too. Btw. nice extension you have there ;) It's sad that VS Code does not expose its bundled ripgrep, since it also searches in unsaved files... |
Hmm, I thought it should be working with unsaved files. I'll have to check that. Ah - it highlights in the unsaved files, but doesn't add them to the tree - not sure where it would put them? I could add an unsaved node... |
I've been using this for the past few days and the colored theme works really well for me. Thank you! |
Thanks ;) I'm thinking of only renaming the identifiers that intersect any of the active selections - I accidentally renamed something I didn't want to rename. What do you think of that? |
Sounds like a useful option. I did the same thing at one point, but I put it down to vscode being over zealous with it's search. |
No description provided.
The text was updated successfully, but these errors were encountered: