Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rename highlighting less visible #5

Closed
hediet opened this issue Jun 24, 2020 · 10 comments
Closed

Make rename highlighting less visible #5

hediet opened this issue Jun 24, 2020 · 10 comments

Comments

@hediet
Copy link
Owner

hediet commented Jun 24, 2020

No description provided.

@Gruntfuggly
Copy link

This would be great - I use a very small font and the highlight makes the text unreadable.

@hediet
Copy link
Owner Author

hediet commented Jul 1, 2020

Do you use the latest version? I've already changed it to a black dashed border. Or is that still to much?
I played a little bit around with it, but it's very hard to find something suitable...

@hediet
Copy link
Owner Author

hediet commented Jul 1, 2020

Do you use the latest version? I've already changed it to a black dashed border like this:
image

Or is that still to much?

Previously it was like this:
image

I played a little bit around with it, but it's very hard to find something suitable...

Do you have ideas?

@Gruntfuggly
Copy link

Gruntfuggly commented Jul 1, 2020

I use a dark theme so it looks like this for me (the error lens isn't helping either, but that's not your fault!):

image

I understand the problem though - in my own extension I ended up adding lots of configuration options for highlights because everybody seems to want something different.

If I'm honest, the background colour works well enough for me.

What is also annoying is that it's not simple to just pass straight CSS into vscode's highlights.

@hediet
Copy link
Owner Author

hediet commented Jul 1, 2020

I see. I think I will add some options too.

Btw. nice extension you have there ;) It's sad that VS Code does not expose its bundled ripgrep, since it also searches in unsaved files...

@Gruntfuggly
Copy link

Gruntfuggly commented Jul 1, 2020

Hmm, I thought it should be working with unsaved files. I'll have to check that. Ah - it highlights in the unsaved files, but doesn't add them to the tree - not sure where it would put them? I could add an unsaved node...

@hediet
Copy link
Owner Author

hediet commented Jul 4, 2020

There is now (0.2.2) this:
image

If you want other themes, please open a pull request!

Just add your theme here, add a new enum entry in package.json for the theme here
and add a screenshot to README.md.

@hediet hediet closed this as completed Jul 4, 2020
@Gruntfuggly
Copy link

I've been using this for the past few days and the colored theme works really well for me. Thank you!

@hediet
Copy link
Owner Author

hediet commented Jul 10, 2020

Thanks ;) I'm thinking of only renaming the identifiers that intersect any of the active selections - I accidentally renamed something I didn't want to rename. What do you think of that?

@Gruntfuggly
Copy link

Gruntfuggly commented Jul 10, 2020

Sounds like a useful option. I did the same thing at one point, but I put it down to vscode being over zealous with it's search.
Maybe a report on what was renamed would be useful in the output panel? I don't know if it is possible to get that information though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants