New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add customization for git ignore file #100
Conversation
Hey, @oliverlee! Thank you for this sophisticated effort to improve things. I'd love to understand a little more what your "needs backtrace" is here. What higher level goals does this resolve for you? (What's going on in my head as I read: Cheers, |
Hi. We have source code spread out across many project repositories. In order to reduce duplication, we have a single tooling repo that brings in linting/formatting/testing/etc. related dependencies - the
|
Define `hedron_compile_commands_setup` to perform installation configuration. Values set during this step remain constant across invocations of `refresh_compile_commands`. This commit introduces a single install config parameter `ignore_file`. If not set, `.gitignore` is used. This can be replaced with the local, unversioned ignore file `.git/info/exclude`.
6c00f49
to
1191aaf
Compare
Hey guys! Sorry for being slow--got a little buried in tasks over here. Resurfacing. I'm so sorry; I promise I'm usually faster, like with my initial replies. After some more thought, I think the move here is to just move over to .git/info/exclude for everyone. I don't see any big downsides compared to the current, and had I known about it when I originally wrote this, I think I should have chosen to do to do it that way, handling more complexity automatically for users. (Conversely, if you think any of that is wrong, please do say!) I'll take a shot at that shortly. Thanks for teaching me something new! Cheers! |
Pointed out in #100 (the other changes buildifier would propose are, I think, a net negative to readability)
This makes ignoring work automagically for people, while minimizing the code changes they have to think about or check in. #100 and #59 are examples of use cases that this simplifies. It also marginally simplifies the case where people can't commit use of this tool to the repo they're working on. IMO tools should to do this more broadly, especially now that git is so dominant. Hidden gitignore documented in https://git-scm.com/docs/gitignore
Sweet! Done in the commits backlinked above. Thanks for a great PR to build on. |
Thanks for incorporating the changes! I think the simpler approach makes sense. As for workspace configuration, that may be useful in the future - I've seen some projects use |
Great :) |
Define
hedron_compile_commands_setup
to perform installation configuration. Values set during this step remain constant across invocations ofrefresh_compile_commands
.This commit introduces a single install config parameter
ignore_file
. If not set,.gitignore
is used. This can be replaced with the local, unversioned ignore file.git/info/exclude
.