Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scripts to call gtrending via the command line #9

Closed
IgnisDa opened this issue Sep 30, 2020 · 11 comments · Fixed by #55
Closed

Add scripts to call gtrending via the command line #9

IgnisDa opened this issue Sep 30, 2020 · 11 comments · Fixed by #55
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@IgnisDa
Copy link

IgnisDa commented Sep 30, 2020

Instead of users having to write python source files to see trending projects, I could add scripts in the setup.py which would do this but via the command line. These scripts would use the gtrending api to achieve this. Let me know your thoughts!

@IgnisDa IgnisDa mentioned this issue Oct 2, 2020
@hedyhli
Copy link
Owner

hedyhli commented Oct 2, 2020

I think this isn't a bad idea, judging by the fact that you can just add some scripts to setup.py which doesn't complicate the whole library and code base itself. However, keep in mind that the intend of this project is a library, not a command line interface, so keep the scripts as lightweight as possible, because there are already several other projects that provide a CLI for fetching github trending, such as mine - starcli - and a few others written in other languages.

@hedyhli hedyhli added enhancement New feature or request good first issue Good for newcomers labels Oct 2, 2020
@IgnisDa IgnisDa removed their assignment Aug 11, 2021
@willtryagain
Copy link

Hi. Can I work on this?

@hedyhli
Copy link
Owner

hedyhli commented Sep 29, 2021

Sure @willtryagain

@bobquest33
Copy link

Is this issue still open, as I see it was assigned to @willtryagain

@willtryagain
Copy link

image

@hedyhli hedyhli linked a pull request Dec 16, 2021 that will close this issue
@hedyhli
Copy link
Owner

hedyhli commented Dec 16, 2021

@bobquest33 yep, it's still open. @willtryagain is working on it over in #37.

image

No worries! Take your time 😄

@devashishmital
Copy link

Hi. Can I work on this if this hasn't been worked on yet?

@willtryagain willtryagain removed their assignment May 19, 2022
@nkitsaini
Copy link

Hi, if this is still open I can make a PR for it. Can you please assign this issue to me in that case?

@hedyhli
Copy link
Owner

hedyhli commented Oct 8, 2022

@devashishmital are you still interested in this?

Hi, if this is still open I can make a PR for it. Can you please assign this issue to me in that case?

@nkitsaini Thanks for your interest. We'll wait for devashishmital's response first.

@nkitsaini
Copy link

@hedyhli Thanks for responding. Yup, fair play 😃

@hedyhli
Copy link
Owner

hedyhli commented Oct 20, 2022

Hi @nkitsaini, given that they haven't responded, I'll assign this to you. Feel free to make a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants