Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃Ч Document database schema in database.py #4678

Open
hasan-sh opened this issue Oct 27, 2023 · 3 comments
Open

馃Ч Document database schema in database.py #4678

hasan-sh opened this issue Oct 27, 2023 · 3 comments
Assignees
Labels
cleanup Issues related to code cleanup, refactoring, resolving technical debt good first issue Good for newcomers

Comments

@hasan-sh
Copy link
Collaborator

Description
Currently, we there's some comments describing certain fields, but not all. Also, how do we know which fields a table hold if a some PR adds a field that's needed?

Idea
We should have an organized schema where all fields are described and can be read in their respective table. So, create a catalog for every table of our database. For instance, in one of the following tools:

@hasan-sh hasan-sh added cleanup Issues related to code cleanup, refactoring, resolving technical debt good first issue Good for newcomers labels Oct 27, 2023
@Felienne Felienne changed the title [CODE] Refactor database schema in database.py [CODE] Document database schema in database.py Oct 30, 2023
@Felienne
Copy link
Member

I think you mean "document" instead of refactor? I think this is a excellent idea! If we go down this road, we should also add a new point to the PR checklist, asking if there are DB changes, and checking if the docs are updated too!

@Felienne
Copy link
Member

Felienne commented Feb 7, 2024

Not a small issue @hasan-sh but something you can pick up in between other things (one table at a time maybe?)

@rix0rrr
Copy link
Collaborator

rix0rrr commented Feb 8, 2024

We can add the types to the Table, which can do things like automatically generate a Markdown report and validate records as they are being inserted into the table.

See a previous attempt for this here: #4862

@Felienne Felienne assigned Felienne and unassigned hasan-sh May 30, 2024
@Felienne Felienne changed the title [CODE] Document database schema in database.py 馃Ч Document database schema in database.py May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Issues related to code cleanup, refactoring, resolving technical debt good first issue Good for newcomers
Projects
Status: In Progress
Development

No branches or pull requests

3 participants