Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default result only got 84 on MSRA #4

Closed
Jarrome opened this issue Jun 8, 2021 · 12 comments
Closed

Default result only got 84 on MSRA #4

Jarrome opened this issue Jun 8, 2021 · 12 comments

Comments

@Jarrome
Copy link

Jarrome commented Jun 8, 2021

Great works! I've read it thoroughly and can easily run your code.

One issue is when I directly use the train-msr and finish train, the final acc is 84 and 83 for two repeat. I think they are with 16 frames. My repeats get lower scoring comparing to the paper.
Screen Shot 2021-06-08 at 9 27 35 AM
Screen Shot 2021-06-08 at 9 27 29 AM

I think it might because there are some parameter change in the script.
Would you be convenient to check out?

@hehefan
Copy link
Owner

hehefan commented Jun 8, 2021

Hi @Jarrome,

This is a bit weird. People usually get slightly better accuracies than the paper. Could you please send the log as well as the environment to me (crane.h.fan@gmail.com)? It could be much better if you could also provide the log with 24 frames. I would like to repeat and check the problem.

Many thanks.

Best regards.

@Jarrome
Copy link
Author

Jarrome commented Jun 9, 2021

Hi, @hehefan,

Thanks for your quick reply. I have emailed you the repo and piplist.
I will now try the 24 frames, and send you latter.

Best regards.

@vivonicole
Copy link

Hi @hehefan,

I also got a slightly lower accuracy 89.2 with 16 frames.

@vivonicole
Copy link

Hi @hehefan

I achieve a 92.68 with 24 frames. Great work.

@hehefan
Copy link
Owner

hehefan commented Jun 10, 2021

Hi @vivonicole,

The accuracy of 89.2 with 16 frames is reasonable. Tuning the radius might improve the performance. Thank you.

Best regards.

@Jarrome
Copy link
Author

Jarrome commented Jun 15, 2021

I close this issue as the problem might be from the compiling of sampling&grouping layer. Not from the authors' work.
It can be reopen, when there is any other find on the clustering step.

@Jarrome Jarrome closed this as completed Jun 15, 2021
@sheshap
Copy link

sheshap commented Dec 27, 2021

Hi @hehefan

I achieve a 92.68 with 24 frames. Great work.

Can you please confirm if this result is for PSTNet or PSTNet++?

I got 90.24 for PSTNet with 24 frames.
Can you please share the logs?

@vivonicole
Copy link

Hi @hehefan
I achieve a 92.68 with 24 frames. Great work.

Can you please confirm if this result is for PSTNet or PSTNet++?

I got 90.24 for PSTNet with 24 frames. Can you please share the logs?

I'm sure it was PSTNet but I did not save the log..

@sheshap
Copy link

sheshap commented Dec 28, 2021

@hehefan

For 24 frames with a batch size of 24, using 4x2080Ti, I got 93.03% accuracy.

What could be the reason for so much fluctuation in accuracy despite setting a random seed for numpy and PyTorch?

@hehefan
Copy link
Owner

hehefan commented Dec 29, 2021

Hi @sheshap,

The fluctuation may be caused by the small scale of the MSR-Action3D dataset and the data augmentation. The accuracy is usually around 91.9±1%.

@sheshap
Copy link

sheshap commented Dec 30, 2021

Thank you for the reply.

In the case of MSR-Action3D, data augmentation is only scaling, right?

As per the datasets/msr.py file below lines:
if self.train:
# scale the points
scales = np.random.uniform(0.9, 1.1, size=3)
clip = clip * scales

Thanks

@hehefan
Copy link
Owner

hehefan commented Jan 2, 2022

Hi @sheshap,

You are right. But note that, because each frame has more than 2048 points. Sampling points is also a random source.

Best regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants