Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Image elements do not have explicit width and height #22

Closed
HEIGE-PCloud opened this issue Apr 25, 2021 · 2 comments · Fixed by #43
Closed

[BUG] Image elements do not have explicit width and height #22

HEIGE-PCloud opened this issue Apr 25, 2021 · 2 comments · Fixed by #43
Labels
bug Something isn't working
Projects
Roadmap
Milestone
v0.2.11

Comments

@HEIGE-PCloud
Copy link
Owner

Reference: https://web.dev/optimize-cls

Related file: \layouts\partials\plugin\image.html

The large CLS caused by the featured picture will let smooth scroll fail to go to the correct place.
@HEIGE-PCloud HEIGE-PCloud added the bug Something isn't working label Apr 25, 2021
@HEIGE-PCloud HEIGE-PCloud added this to the v0.2.11 milestone Apr 25, 2021
@HEIGE-PCloud HEIGE-PCloud added this to To do in Roadmap Apr 28, 2021
@HEIGE-PCloud
Copy link
Owner Author

Reference: https://gohugo.io/content-management/image-processing/#readout

@HEIGE-PCloud
Copy link
Owner Author

The loading svg is causing a lot of problems. I am considering replace the lazysizes lazy load with some native method.

@HEIGE-PCloud HEIGE-PCloud linked a pull request May 2, 2021 that will close this issue
[FIX] Add explicit width and height to image elements #43
Merged
Roadmap automation moved this from To do to Done May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
Roadmap
  
Done
Milestone
v0.2.11
Development

Successfully merging a pull request may close this issue.

[FIX] Add explicit width and height to image elements HEIGE-PCloud/DoIt
1 participant
@HEIGE-PCloud