Implement nic on windows

[daladim]

Hello, I had to implement a piece of heim for my needs, let"s share it!

This MR implements heim::net::nic() on Windows using the GetAdaptersAddresses API.
It closes #24

It also adds an index() member function for Nics on Windows, macOS and Linux

[coveralls]

Coverage increased (+3.8%) to 38.279% when pulling aa790c7 on daladim:implement_nic_on_windows into c111eb4 on heim-rs:master.

[svartalf]

Hey, @daladim, amazing work!

There is a lot to review and due to holiday season I'm not sure if I'll be able do that very soon, but your change looks very helpful and promising, so I'll try my best to do that asap

[daladim]

Hi @svartalf , did you have time to review these changes? Do you want any help to do so?

[svartalf]

@daladim I'm sorry, definitely not cool from my side.
I started reviewing it a few days ago and will try to finish soon; so far everything looks great, but you should be very careful with unsafe after all :)

[svartalf]

Looks good in general, I have one tiny nitpick regarding the mem::size_of usage and after that I'll merge this PR

[svartalf]

As a reminder: after all reviews it would be nice to create tracking issues for this and above TODOs in order not to forget about these things.

[roblabla]

https://todo.jasonet.co/ I've used this in some projects to great effect. It's a bot that automatically opens issues for TODO comments when merging a PR. Thought you might be interested ^^.

[daladim]

@daladim I'm sorry, definitely not cool from my side.

Nothing to hurry about, I was just checking all my pending pull requests. Thanks for the review!

[svartalf]

I've also found GetIfTable2 and MIB_IF_ROW2, which is also used by psutil (except they are using outdated GetIfTable).

Looks like it also have a lot of interesting information, @daladim, I'm curious if you checked it before? GetInterfaceAddresses covers current public API, but this thing is also might be interesting.

Unfortunately, I can't find how to provide information for destination and is_running methods, which means that if we will not be able to figure them out, I'll demote them to be *nix-specific methods and move into heim::net::os::nix::NicExt (it is out of scope for this PR, though).

[daladim]

@daladim, I'm curious if you checked it before?

There are indeed quite a few Microsoft APIs to retrieve info about network interfaces. I've had a look at all of them (at least all which are part of the IP Helper API), but it turns out GetAdaptersAddresses is the only one that supports both loopback interfaces and IPv6, so that's the one I've used.

[daladim]

As to the merge conflicts, do you prefer a rebase on master, or a merge commit that merges master on my current branch?

[svartalf]

but it turns out GetAdaptersAddresses is the only one that supports both loopback interfaces and IPv6, so that's the one I've used.

Thanks, looks like the best choice we have :)

As to the merge conflicts, do you prefer a rebase on master, or a merge commit that merges master on my current branch?

No personal choice from me, I usually just squashing branches before merge into master branch :|

[daladim]

I've rebased on master to solve the merge conflicts (basically due to the + Sync + Send that you added on the trait while I edited the lines around these signatures)

[svartalf]

Some new clippy lint breaks CI, but I'll fix that separately on my own.
Alright, this is huge addition and a tremendeous amount of work, thanks you so much, @daladim!