Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to version 1.11.0 destroys German umlauts #6

Closed
plorenz-etes opened this issue Jan 21, 2022 · 8 comments
Closed

Updating to version 1.11.0 destroys German umlauts #6

plorenz-etes opened this issue Jan 21, 2022 · 8 comments

Comments

@plorenz-etes
Copy link

Context
Contao version: 4.9.24
Bundle version: 1.11.0
PHP version: 7.4

Description
After upgrading to version 1.11.0 (coming from 1.10.3), German umlauts are destroyed.

Before: Der führende Anbieter...
After: Der führende Anbieter...

However, this is not an issue with broken character encoding. Viewing the source code, the following can be found:

Der führende Anbieter

Downgrading to version 1.10.3 again solved the issue for me.

@koertho
Copy link
Contributor

koertho commented Jan 21, 2022

Hi, the only change in 1.11 was the library update. Could you try 1.11 with wa72/htmlpagedom 1.4 and check, if it still works?

@plorenz-etes
Copy link
Author

I tried installing wa72/htmlpagedom 1.4.2 alongside heimrichhannot/contao-hyphenator-bundle 1.11.0 but it results in dependency errors which I unfortunately don't know how to resolve: https://pastebin.com/QZ2nZENQ

@koertho koertho closed this as completed in 3a9670a May 5, 2022
@koertho
Copy link
Contributor

koertho commented May 5, 2022

I just could reproduce this problem and hopefully fixed it in 1.11.1

@plorenz-etes
Copy link
Author

Thank you, that fixed it for me as well! :)

@koertho
Copy link
Contributor

koertho commented May 9, 2022

Thanks for the feedback!

@plorenz-etes
Copy link
Author

Seems like I was a bit too quick here - umlauts work fine now, but e.g. the following signs are replaced by question marks:

  • – (–)
  • ◀ (◀) and ▶ (▶), used for slider controls

I did a rollback to 1.10.3 for now.

@koertho
Copy link
Contributor

koertho commented May 10, 2022

Did you try 1.11.2?

@plorenz-etes
Copy link
Author

Ah no, actually I didn't. Tried it now and it works fine, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants