Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook #3

Closed
zonky2 opened this issue Sep 14, 2018 · 9 comments
Closed

Hook #3

zonky2 opened this issue Sep 14, 2018 · 9 comments

Comments

@zonky2
Copy link

zonky2 commented Sep 14, 2018

Haben MetaModels gefixt, um diesen hübschen Querschläger abzufangen...
https://github.com/heimrichhannot/contao-multi_column_editor/blob/master/classes/Hooks.php#L45

dürfte anderen Erweiterungen ähnlich gehen...

@Defcon0
Copy link

Defcon0 commented Sep 17, 2018

Fixed in e9a6b62.

Please note that contao-multi_column_editor is abandoned. https://github.com/heimrichhannot/contao-multi-column-editor-bundle is the current one which is for Contao 4.

What also might be intersting is, how you fixed it in MetaModels.

@Defcon0 Defcon0 closed this as completed Sep 17, 2018
@zonky2
Copy link
Author

zonky2 commented Sep 17, 2018

@Defcon0
Copy link

Defcon0 commented Sep 17, 2018

Ah ok, thanks. Maybe you could test the extension if it works now? It should, but just to be sure ;-)

@dmolineus
Copy link

Don't you still set a field in dca.fields.NAME to true? Which should cause issues with every extension expecting an array here as it's the expected behaviour in contao...

@Defcon0
Copy link

Defcon0 commented Sep 18, 2018

Ah, I see. I do this since the fields in eval -> multiColumnEditor -> fields don't really exist for Contao. If I remove the "true" and do an ajax call in one of the fields in multi_column_editor, I get the exception from contao that the field doesn't exist.

But if the problem is just that it shouldn't be truebut [], I can easily fix that. Or would it be better to add the fields to the normal dca automatically but without sql so that we don't have them in the db?

@dmolineus
Copy link

Setting an empty array would be better I think. I don't know how the multi column editor works (I know it needs some hacks to overcome Contao limitations for advanced widgets though), but I think it should be okay to keep an empty array as Contao does not enforce you to have an inputType f.e.

@zonky2
Copy link
Author

zonky2 commented Sep 18, 2018

@Defcon0 What is the reason not to use the MCW or to program your own "MCW"?

@Defcon0
Copy link

Defcon0 commented Sep 18, 2018

OK, fixed in ced0ab9.

Reason for why we built multi column editor is answered in the README.md of this module ;-)

The module is similar to menatwork/MultiColumnWizard but works in frontend as well (in combination with the form generator module heimrichhannot/contao-formhybrid).

@zonky2
Copy link
Author

zonky2 commented Sep 18, 2018

o.k. ... we push the MCW to the FE for front-end-editing in MM - see https://github.com/richardhj/contao-multicolumnwizard-frontend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants