Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CharacterCore::m_HookTick should have type Duration not Instant despite name #93

Open
Zwelf opened this issue Feb 26, 2024 · 0 comments

Comments

@Zwelf
Copy link
Contributor

Zwelf commented Feb 26, 2024

m_HookTick has the type NetTick in protocol.py, but is used as HookDuration. Starting with zero and incrementing one each tick until the roughly 60 ticks = 1.2s are passed.

libtw2 uses the Instant type, but Duration would be more correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant