Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DrawerView.java #75

Closed
wants to merge 1 commit into from
Closed

Update DrawerView.java #75

wants to merge 1 commit into from

Conversation

SMontiel
Copy link

@SMontiel SMontiel commented Dec 3, 2015

Compile the demo app with two profiles and one draweritem, compile with the version 2.2.0 and the library in this repo just compare it. You 'll see the issues

Issue two profiles
@heinrichreimer
Copy link
Owner

Please describe what this pull request is for. You make two very unclear code changes...

@SMontiel
Copy link
Author

SMontiel commented Dec 4, 2015

@SMontiel
Copy link
Author

SMontiel commented Dec 4, 2015

profiles do not change.

@heinrichreimer
Copy link
Owner

What I don't understand is this change:

-    private boolean profileListOpen = false;
+   //Before
+//--private boolean profileListOpen = false;
+   //After Salvador Montiel
+    private boolean profileListOpen = true;

That is unlogical since the profile list is closed initially.

@heinrichreimer
Copy link
Owner

I'll most likely merge this by hand as there are some unneeded comments in your pull request. Thanks for working on this annoying bug! I'll leave the first change as it is now:

private boolean profileListOpen = false;

@SMontiel
Copy link
Author

SMontiel commented Dec 4, 2015

If you don't change this line

private boolean profileListOpen = false;

to

private boolean profileListOpen = true;

the error is this:
https://drive.google.com/file/d/0B90o7iqpIsEsOV9YM3pFV3NYMms/view

@SMontiel
Copy link
Author

SMontiel commented Dec 4, 2015

when switching between profiles, the profile list is shown down of DrawerItems

heinrichreimer added a commit that referenced this pull request Dec 6, 2015
Updated Gradle dependencies
Improved base code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants