Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CoordinatorLayout instead of FrameLayout for Material powa #49

Closed
DomenicoCasillo opened this issue May 9, 2016 · 1 comment
Closed

Comments

@DomenicoCasillo
Copy link

In /res/layout/activity_intro.xml the library uses a FrameLayout as main element. However this prevents us from achieving all the Material's goodness. For example as in your demo app, when showing a Snackbar the Fabs and the InkIndicator doesn't move with the Snackbar, and they get behind it.
Would it be possible to use a CoordinatorLayout instead of a FrameLayout to achive such advantages?

Thanks.

@heinrichreimer
Copy link
Owner

They are not FABs (That would be completely against the guidelines 😆) just image buttons.
I decided to not move the controls up because they are on the main surface, the same as the text and image. If they get moved up, they'd cover the image or text and destroy the material metaphor.
And of course using CoordinatorLayout everywhere just because it helps acheiving material effects can have a bad impact on app performance. FrameLayout in most cases is the fastest layout you can use on Android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants