Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an error if no background is given to SimpleSlide.Builder #76

Closed
JuliCodes opened this issue Jun 9, 2016 · 1 comment
Closed

Comments

@JuliCodes
Copy link

Hey,

you developed a really great library.

There ist just one annoying thing for beginners. If i don't supply a background color to the SimpleSlide.Builder and run the generated code on any device (tested on 1+1 with CM13 and several emulators i got an RessourceNotFoundException.

My suggestion:

  • Either documentate this behavior in the Readme
  • Or throw a more helping message than the system does.

If wished, i can create a pull request.

Greetings

@heinrichreimer
Copy link
Owner

Yeah, you can create a pull request for that. Look at FragmentSlide.Builder.build() on how this may look. (Think I have simply missed to implement this in SimpleSlide too 😄)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants