Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance #10

Closed
Jellix opened this issue May 30, 2020 · 2 comments
Closed

Improve performance #10

Jellix opened this issue May 30, 2020 · 2 comments
Assignees
@Jellix
Labels
enhancement New feature or request
Projects
Roadmap

Comments

@Jellix
Copy link
Member

Jellix commented May 30, 2020 •
edited
Loading

Right now, when printing entities filtered by --failed or --unproved, the decision if the entity's proof tree has failed attempts results in multiple calls to Has_Failed_Attempts, Is_Unproved which each cause more similar calls into all dependent objects. This should be optimized, so that such properties are only calculated once.

For further discussion see this wiki-page
@Jellix Jellix added the enhancement New feature or request label May 30, 2020
@Jellix Jellix self-assigned this May 30, 2020
@Jellix Jellix pinned this issue Jun 6, 2020
@Jellix Jellix unpinned this issue Jun 6, 2020
@Jellix Jellix added this to In progress in Roadmap Jun 6, 2020
Jellix added a commit that referenced this issue Jun 8, 2020
@Jellix
Performance #10 (#15)
73cfaa3 
* All concerned entities are now derived from Entity.T.
* Less ugly template file names.
* All entities are in the same tree now
* Enable Assertion checks.
* Enabled paralled compilation ('-j0' switch).
@Jellix
Copy link
Member Author

Jellix commented Jun 10, 2020

Mostly fixed in b667fca

Which bears the question... when we are collecting the proof items, we now already know if the item would get filtered. So maybe don't add these to the tree at all. That should greatly simplify the output code.

@Jellix
Copy link
Member Author

Jellix commented Jun 10, 2020

I think we can close this now. The major overhaul is done.

@Jellix Jellix closed this as completed Jun 10, 2020
Roadmap automation moved this from In progress to Done Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jellix Jellix

Labels
enhancement New feature or request
Projects
Roadmap
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Jellix