Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spurious warnings #17

Closed
Jellix opened this issue Jun 10, 2020 · 0 comments · Fixed by #19
Closed

Fix spurious warnings #17

Jellix opened this issue Jun 10, 2020 · 0 comments · Fixed by #19
Assignees
@Jellix
Labels
enhancement New feature or request
Projects
Roadmap

Comments

@Jellix
Copy link
Member

Jellix commented Jun 10, 2020 •
edited
Loading

For SPARK CE 2020, we spit out warnings that an (empty) check_tree is not a JSON array, because with the 2020 file format, an empty JSON object appears there instead of the expected array (i.e. [] vs. {}).

We should probably relax this check, i.e. this requires warning-less Preconditions.
@Jellix Jellix added the enhancement New feature or request label Jun 10, 2020
@Jellix Jellix self-assigned this Jun 10, 2020
@Jellix Jellix added this to To Do in Roadmap Jun 10, 2020
@Jellix Jellix moved this from To Do to In progress in Roadmap Jun 10, 2020
@Jellix Jellix linked a pull request Jun 11, 2020 that will close this issue
* Removed warnings for check_tree being of wrong type. #19
Merged
Roadmap automation moved this from In progress to Done Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jellix Jellix

Labels
enhancement New feature or request
Projects
Roadmap
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

* Removed warnings for check_tree being of wrong type. HeisenbugLtd/spat
1 participant
@Jellix