Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect warning about missing timings #6

Closed
kanigsson opened this issue May 28, 2020 · 3 comments · Fixed by #7
Closed

Incorrect warning about missing timings #6

kanigsson opened this issue May 28, 2020 · 3 comments · Fixed by #7
Assignees
@Jellix
Labels
bug Something isn't working

Comments

@kanigsson
Copy link

When running SPAT on a toy project, I get warnings like these:

Warning: Expected field "gnatwhy3.run_vcs" not present!
Warning: Expected field "gnatwhy3.register_vcs" not present!
Warning: Expected field "gnatwhy3.schedule_vcs" not present!

But it's expected to have such missing fields, it just means the corresponding phase wasn't run at all. For the statistics, the tool should assume the phase took no time (0s).
@kanigsson
Copy link
Author

More generally, concerning timings, it seems strange to pick just those three to account for "proof". In fact all timings prefixed with "gnatwhy3" could be assigned to "proof", and all the prover timings as well.

@Jellix
Copy link
Member

Jellix commented May 28, 2020 •
edited
Loading

This was a quick fix related to the changes in the file format in the 2020 community release (see spat-timing_items.adb). The 2019 version had a field "proof" which disappeared in 2020. Guess I have to bite the bullet and instead of relying on the information in the timings object just add all times from the single proofs for the summary output.

@Jellix Jellix self-assigned this May 28, 2020
@Jellix Jellix added the bug Something isn't working label May 28, 2020
@Jellix Jellix linked a pull request May 28, 2020 that will close this issue
Fixes for issue #6 #7
Merged
@Jellix Jellix closed this as completed in #7 May 28, 2020
Jellix added a commit that referenced this issue May 28, 2020
@Jellix
Fixes for issue #6
112a032 
* Collect all gnatwhy3 prefixed timings into the proof timing entity.
  Gets rid of warnings about missing required fields, as these fields are technically not 'required'.
* Implemented summing of proof times for GNAT CE 2020.
* Fixed a bug in the time accumulation function.
@Jellix
Copy link
Member

Jellix commented May 28, 2020 •
edited
Loading

Thanks for the report. I implemented your suggested changes and even found a defect in the calculation of the total proof time.

The warnings should be gone now, and the reported timings in the summary should be more accurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jellix Jellix

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes for issue #6 HeisenbugLtd/spat
2 participants
@kanigsson @Jellix