Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove os.system calls #3

Open
hejops opened this issue Feb 5, 2024 · 0 comments
Open

Remove os.system calls #3

hejops opened this issue Feb 5, 2024 · 0 comments

Comments

@hejops
Copy link
Owner

hejops commented Feb 5, 2024

Aside from file.convert and the following 2 commands,

  • clear (tag.fix)
  • mpv (play.pmp)

calls to os.system should be minimised:

  • cat
  • echo
  • find
  • ls / exa
  • ncdu (file.mover)
  • notify-send
  • rm
  • waitdie
  • xdg-open
  • xset (play.pmp)

Some of the above commands will be found in any typical Linux distribution, and
were used for QOL features (e.g. notifications, file cleanup) that I didn't
feel like implementing myself.

However, the following commands are unlikely to be universal, and should
be replaced:

  • ncdu
  • notify-send
  • waitdie -- a personal script of mine that is a wrapper for tail -f
  • xdg-open
  • xset
@hejops hejops mentioned this issue Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant