Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misplacement of connections between neurons in NeuralNetworkScene #33

Closed
baichuanzhou opened this issue Feb 24, 2023 · 5 comments
Closed

Comments

@baichuanzhou
Copy link

I tried to run the example code below:

class NeuralNetworkScene(Scene):
    def construct(self):
        layers = [FeedForwardLayer(3), FeedForwardLayer(5), FeedForwardLayer(3)]
        nn = NeuralNetwork(layers)
        self.add(nn)
        nn.move_to(ORIGIN)
        # nn.scale(2)
        forward_propagation_animation = nn.make_forward_pass_animation(
            run_time=5, passing_flash=True
        )
        self.play(forward_propagation_animation)

And everything is fine.
But when I uncomment nn.scale(2), this happened:
image
It appears that the connections between neurons are misplaced when scaling.

@helblazer811
Copy link
Owner

Sorry I never responded to this. I am pretty busy for the next few weeks, but after that I will look into this issue.

@helblazer811
Copy link
Owner

Sorry this took so long for me to get back to this. I think I have fixed this. Let me know if you can update your pip package with pip install --upgrade manim-ml. Let me know if it works.

@helblazer811
Copy link
Owner

Closing this unless it still does not work.

@baichuanzhou
Copy link
Author

Sorry I didn't see your comments before. It works, thank you.

@helblazer811
Copy link
Owner

helblazer811 commented Apr 17, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants