I2CMasterSlaveDriver: add write_read
command.
#681
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request adds a libtock wrapper for the i2c
write_read
trait because previously it was not possible to call it from userland.Testing Strategy
I tested using a Salae and the NRF52:
This was a i2c write-read transaction against a i2c EEPROM peripheral.
TODO or Help Wanted
This pull request should be ready to merge. The only question is the buffer overwrite behaviour of
write_read
. It is not clear if the received bytes are written to the beginning of the buffer, or written after the bytes that were transmitted. Currently we assume the received bytes are written starting at index 0 of the buffer.Documentation Updated
/docs
have been updated or no updates are required.Formatting
make formatall
has been run.@JayKickliter also contributed to this.