Fix docs #755
Merged
Fix docs #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to ensure rustup toolchain is set correctly and that rustdoc is given an absolute path for things to work now
ppannuto
added
the
P-Upkeep
Closed
Apparently not all Make's have $(TMPDIR)
We were doing tricks with the rustdoc arguments to allow us to document private fields, but now there is just a flag for it.
rustdoc changed which markdown parser it is using. It now throws a warning if your docs will look different. Essentially this commit fixes our docs so they will look "right" by changing them to what they should have been before.
alevy
approved these changes
Feb 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
Our docs haven't been building for a little while (likely since the last nightly bump). This fixes their invocation so they build again.
Testing Strategy
Building docs locally.
Documentation Updated / Formatting
N/A