Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip install femwell #14

Closed
joamatab opened this issue Dec 21, 2022 · 6 comments
Closed

pip install femwell #14

joamatab opened this issue Dec 21, 2022 · 6 comments

Comments

@joamatab
Copy link
Contributor

Can you release a new version?

femwell depends on scikit-fem@ git+https://github.com/requests/requests.git

image

gdsfactory/gdsfactory#1032

@HelgeGehring
Copy link
Owner

HelgeGehring commented Dec 21, 2022

Yes, I'll do a new release soon and then do it more often :) Up to now it was blocked by the usage of new features of scikit-fem, which were not yet in the pypi release.

@joamatab
Copy link
Contributor Author

nice, you can add .bumpersion to increase version number and tag the commits for each release

this may be helpful
https://github.com/joamatab/cookiecutter-pypackage-minimal

let us know when you upload the new version

@simbilod

@HelgeGehring
Copy link
Owner

I've just released a new version, now it should work!
The installation of slepc4py is still a bit complicated, I've described it in https://helgegehring.github.io/femwell/install.html , would be happy about an easier way :/

The release is now automatically done on new tags and the the version is automatically derived from the tag (https://github.com/HelgeGehring/femwell/blob/main/.github/workflows/release.yml)

I'll have a look on the template, thanks!

@joamatab
Copy link
Contributor Author

joamatab commented Jan 3, 2023

it works 🎉

it would be nicer to have a simpler install method

https://gitlab.com/petsc/petsc/-/issues/1303

@HelgeGehring
Copy link
Owner

Thanks for opening the issue!
The best option would be to have some pecompiled wheels, compiling petsc and slepc takes something like 10min :/

@HelgeGehring
Copy link
Owner

I'll close this one now, as we're now relying as the standard solver on scipy which is easy to install :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants