Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleXmlParser: Processing instructions are not handled #780

Closed
ljnelson opened this issue Sep 6, 2022 · 1 comment · Fixed by #785
Closed

SimpleXmlParser: Processing instructions are not handled #780

ljnelson opened this issue Sep 6, 2022 · 1 comment · Fixed by #785
Assignees
Labels
2.x Applies to the 2.x branch 3.x bug Something isn't working cli P1
Milestone

Comments

@ljnelson
Copy link
Member

ljnelson commented Sep 6, 2022

Permitted states do not include processing instructions:

https://github.com/oracle/helidon-build-tools/blob/d216b571bb03abd5b08f5a6c65077892e373a871/common/xml/src/main/java/io/helidon/build/common/xml/SimpleXMLParser.java#L226-L239

The manifesting symptom is that in a processing instruction like this:

<?m2e execute onConfiguration,onIncremental?>

…the parser bails out here:

https://github.com/oracle/helidon-build-tools/blob/d216b571bb03abd5b08f5a6c65077892e373a871/common/xml/src/main/java/io/helidon/build/common/xml/SimpleXMLParser.java#L593-L594

@romain-grecourt romain-grecourt added 2.x Applies to the 2.x branch 3.x bug Something isn't working cli P1 labels Sep 6, 2022
@romain-grecourt romain-grecourt added this to the 3.0.1 milestone Sep 6, 2022
@romain-grecourt
Copy link
Contributor

romain-grecourt commented Sep 6, 2022

Steps to reproduce with the helidon cli:

  • generate a quickstart/mp project
  • edit jandex-maven-plugin execution like this:
<plugin>
    <groupId>org.jboss.jandex</groupId>
    <artifactId>jandex-maven-plugin</artifactId>
    <executions>
        <execution>
            <?m2e execute onConfiguration,onIncremental?>
            <id>make-index</id>
        </execution>
    </executions>
</plugin>
  • remove .helidon
  • run helidon dev

@barchetta barchetta changed the title Processing instructions are not handled SimpleXmlParser: Processing instructions are not handled Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Applies to the 2.x branch 3.x bug Something isn't working cli P1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants