Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MergedModel.resolveModel should not require the root scope #878

Closed
romain-grecourt opened this issue Feb 1, 2023 · 0 comments · Fixed by #923
Closed

MergedModel.resolveModel should not require the root scope #878

romain-grecourt opened this issue Feb 1, 2023 · 0 comments · Fixed by #923
Assignees
@tvallin
Labels
3.x archetype bug Something isn't working
Milestone
3.0.5

Comments

@romain-grecourt
Copy link
Contributor

The root scope can only be required when doing a full traversal. However MergedModel.resolveModel can be used to resolve scope model and in that case the scope cannot be expected to be the root scope.

We should remove the method Context.requireRootScope() and instead update Controller.walk to enforce that the context scope is same before and after traversal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tvallin tvallin

Labels
3.x archetype bug Something isn't working
Projects
None yet
Milestone
3.0.5
Development

Successfully merging a pull request may close this issue.

MergedModel.resolveModel should not require the root scope tvallin/helidon-build-tools
2 participants
@romain-grecourt @tvallin