Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate websocket support #123

Closed
romain-grecourt opened this issue Oct 19, 2018 · 7 comments
Closed

Investigate websocket support #123

romain-grecourt opened this issue Oct 19, 2018 · 7 comments
Labels
enhancement New feature or request

Comments

@romain-grecourt
Copy link
Contributor

Netty has support for websocket.
Investigate how the webserver API could be used to handle websockets.

See some netty + websocket blog post: https://medium.com/@irunika/how-to-write-a-http-websocket-server-using-netty-f3c136adcba9

@romain-grecourt romain-grecourt added the enhancement New feature or request label Oct 31, 2018
@romain-grecourt
Copy link
Contributor Author

See also #143

@dansiviter
Copy link
Contributor

Could this be via WebSocket 1.1 Spec (JSR356) APIs? I know you're not trying to write the next JEE container here but I'll make porting code to Helidon easier.

@spericas
Copy link
Member

Just as we did for REST in MP using JAX-RS, we should consider JSR356 for WS. I agree that it would help migration to Helidon MP.

@AshwinPrabhuB
Copy link

WebSockets would definitely help in use cases that require a server push. With the current Helidon infra, I guess the max one can achieve is a SSE with a long running Handler. But a WebSocket protocol support within Helidon would definitely help us avoid a parallel stack like Node just for the push capability.

@dansiviter
Copy link
Contributor

Any update on this?

I've had a look into this and it looks like both a 'native' API as well as a JSR356 implementation would be needed especially if reusing the Netty implementation of websockets as it's somewhat buried under Server[Request|Response] and Bare[Request|Response].

I'm tempted to have a bash at it so any guidance on style?

@eduvim
Copy link

eduvim commented Oct 26, 2019

I would like to help to implement this, I mean it's an important feature to be added and critical if we think on jax rs. In order to be logical I am thinking just on apply the medium blog's idea, then we can add it to helidon and for the last we should think on something like a SocketSeevices

@spericas
Copy link
Member

@eduvim Please see #927. There's already a simple prototype that integrates with Helidon SE. We are targeting this work for Helidon 2.0. I'm going to close this issue so that we can continue discussion over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants