Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use com.sun.activation:jakarta.activation instead of jakarta.activation-api #2770

Closed
lukasj opened this issue Feb 16, 2021 · 4 comments
Closed
Assignees
Projects

Comments

@lukasj
Copy link

lukasj commented Feb 16, 2021

Environment Details

  • Helidon Version: 2.2.1

Problem Description

Helidon currently removes jakarta.activation artifact from all its dependencies and uses jakarta.activation-api artifact instead. Problem with this is that the -api artifact contains no implementation and whoever depends on it may get unexpected behaviour due to missing functionality. Also note that jakarta.activation-api artifact may not be able to start properly on JPMS/OSGi due to missing implementation classes (that's activation's problem to be solved in that project).

@barchetta barchetta added this to Needs triage in Backlog via automation Feb 18, 2021
@m0mus m0mus added P3 P4 and removed P3 labels Feb 25, 2021
@m0mus m0mus moved this from Needs triage to Low priority in Backlog Feb 25, 2021
@tomas-langer tomas-langer removed their assignment Feb 6, 2023
@tomas-langer tomas-langer moved this from Low priority to Triage in Backlog Feb 6, 2023
@m0mus m0mus added P3 and removed P4 labels Feb 6, 2023
@m0mus m0mus moved this from Triage to Normal priority in Backlog Feb 6, 2023
@tomas-langer
Copy link
Member

Use Angus activation as the implementation
Upgrade activation API to the latest version

@barchetta barchetta moved this from Normal priority to Sprint Scope in Backlog Feb 16, 2023
@barchetta
Copy link
Member

In 4.0 it appears as though we can remove almost all dependency on jakarta.activation. See PR #6138. I still need to investigate 3.x.

@lukasj
Copy link
Author

lukasj commented Feb 22, 2023

the right combination to use is jakarta.activation-api on the compile scope and angus-activation on the runtime scope, if activation as such is needed

@barchetta
Copy link
Member

With the latest PRs we have, for the most part, removed the dependency on jakarta.activation-api from Helidon 2, 3 and 4. With that I think this issue no longer applies so I'm closing it.

Backlog automation moved this from In Progress to Closed Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Backlog
  
Closed
Development

No branches or pull requests

4 participants