Unable to unset backward-compatible-eol in HttpSignProvider

[janotav]

Environment Details

• Helidon Version: 2.4.2
• Helidon SE
• JDK version: 14.0.2
• OS: Linux
• Docker version (if applicable):

---

Problem Description

Unable to perform OCI signed requests. Due to typo in OutboundTargetDefinition the backward-comptabible-eol is always enabled even when config explicitly disables it.

 public Builder config(Config config) {
            Builder builder = new Builder();

            // mandatory
            builder.keyId(config.get("key-id").asString().get());
            config.get("header").asString().map(HttpSignHeader::valueOf).ifPresent(builder::header);
            config.get("sign-headers").as(SignedHeadersConfig::create).ifPresent(builder::signedHeaders);
            config.get("private-key").as(KeyConfig::create).ifPresent(builder::privateKeyConfig);
            config.get("hmac.secret").asString().ifPresent(builder::hmacSecret);

            // last, as we configure defaults based on configuration
            config.get("algorithm").asString().ifPresent(builder::algorithm);

            // backward compatibility with previous Helidon versions
            config.get("backward-compatible-eol").asBoolean().ifPresent(this::backwardCompatibleEol); // <--- should be builder::backwardCompatibleEol instead of this::backwardCompatibleEol, correct?

            return builder;
        }

[spericas]

@tomas-langer Could you comment on this one? I does indeed look odd that we use this on that line. But I'm also not sure why this config method creates and returns a new builder.

[tomas-langer]

That is indeed a bug. The method should update the current instance, never create a new one.

[tomas-langer]

What kind of OCI requests are you doing? We do have a separate framework for calling OCI that works (it uses a dedicated OCI specific security provider).
We have implementations for vault, object storage and a few other APIs for Helidon SE.
There is more to the OCI communication than the signatures, and we should be covering that.

[janotav]

In the bigger picture, we need the ability to call various OCI services. Our primary scenario is calling OCI Datascience Model Deployment prediction service using Resource Principals (2.2). Unfortunately this functionality is not implemented as of Helidon SE 2.4.2

[spericas]

PR #3913