Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON output for SimpleTimer is always in seconds; it should be expressed in whatever units are set in the metadata #4240

Closed
tjquinno opened this issue May 19, 2022 · 0 comments
Assignees
Labels
2.x Issues for 2.x version branch 3.x Issues for 3.x version branch bug Something isn't working metrics P2
Projects
Milestone

Comments

@tjquinno
Copy link
Member

Environment Details

  • Helidon Version: 2.x, 3.x
  • Helidon SE or Helidon MP
  • JDK version:
  • OS:
  • Docker version (if applicable):

Problem Description

JSON format output should express data values in the units defined in the metadata for the metric. For SimpleTimers the JSON-formatted elapsedTime is always expressed in seconds, regardless of the units specified in the SimpleTimer's metadata.

Steps to reproduce

Create a HelidonSimpleTimer (our implementation of SimpleTimer) specifying something other than seconds as the units in the metadata. Update the simple timer with some value. Invoke the HelidonSimpleTimer#jsonData method. The elapsedTime key in the resulting JsonObject will be incorrectly expressed in seconds.

@tjquinno tjquinno added bug Something isn't working metrics P2 2.x Issues for 2.x version branch 3.x Issues for 3.x version branch labels May 19, 2022
@tjquinno tjquinno added this to the 2.5.1 milestone May 19, 2022
@tjquinno tjquinno self-assigned this May 19, 2022
@tjquinno tjquinno added this to Triage in Backlog via automation May 19, 2022
@tjquinno tjquinno moved this from Triage to In Progress in Backlog May 19, 2022
@tjquinno tjquinno moved this from In Progress to Closed in Backlog May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Issues for 2.x version branch 3.x Issues for 3.x version branch bug Something isn't working metrics P2
Projects
Backlog
  
Closed
Development

No branches or pull requests

1 participant