Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The app.yaml included in the template created by helidon cli is incorrect #4746

Closed
shukawam opened this issue Aug 17, 2022 · 1 comment
Closed
Assignees
Labels
3.x Issues for 3.x version branch archetypes bug Something isn't working P2
Milestone

Comments

@shukawam
Copy link

Environment Details

  • Helidon Version: 3.0.1
  • Helidon SE or Helidon MP: MP
  • JDK version: 17
  • OS: Oracle Linux
  • Docker version (if applicable):

Problem Description

The app.yaml (Kubernetes Manifest) included in the template created by helidon cli is incorrect.
Deployment should exist...

Steps to reproduce

$ helidon init
Helidon version (default: 3.0.1): 

| Helidon Flavor

Select a Flavor
  (1) se | Helidon SE
  (2) mp | Helidon MP
Enter selection (default: 1): 2

| Application Type

Select an Application Type
  (1) quickstart | Quickstart
  (2) database   | Database
  (3) custom     | Custom
Enter selection (default: 1): 1

| Media Support

Select a JSON library
  (1) jackson | Jackson
  (2) jsonb   | JSON-B
Enter selection (default: 1): 1

| Customize Project

Project groupId (default: me.opc-helidon): 
Project artifactId (default: quickstart-mp): 
Project version (default: 1.0-SNAPSHOT): 
Java package name (default: me.opc.mp.quickstart): 

Switch directory to /home/opc/git/quickstart-mp to use CLI

Start development loop? (default: n):

then

 $ cat quickstart-mp/app.yaml 
#
# Copyright (c) 2018, 2021 Oracle and/or its affiliates. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#

kind: Service
apiVersion: v1
metadata:
  name: quickstart-mp
  labels:
    app: quickstart-mp
spec:
  type: NodePort
  selector:
    app: quickstart-mp
  ports:
  - port: 8080
    targetPort: 8080
    name: http
---
@github-actions github-actions bot added this to Triage in Backlog Aug 17, 2022
@romain-grecourt romain-grecourt added this to the 3.0.2 milestone Aug 17, 2022
@romain-grecourt
Copy link
Contributor

The copyright header should also be removed.

@arjav-desai arjav-desai self-assigned this Aug 24, 2022
@arjav-desai arjav-desai added bug Something isn't working 3.x Issues for 3.x version branch labels Aug 24, 2022
@barchetta barchetta added the P2 label Aug 25, 2022
@barchetta barchetta moved this from Triage to High priority in Backlog Aug 25, 2022
@barchetta barchetta added 3.next and removed 3.next labels Aug 25, 2022
@barchetta barchetta added this to To do in 3.0.2 Aug 25, 2022
@m0mus m0mus moved this from High priority to In Progress in Backlog Sep 8, 2022
@m0mus m0mus moved this from In Progress to Sprint Scope in Backlog Sep 8, 2022
@arjav-desai arjav-desai moved this from To do to Done in 3.0.2 Sep 20, 2022
Backlog automation moved this from Sprint Scope to Closed Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issues for 3.x version branch archetypes bug Something isn't working P2
Projects
Backlog
  
Closed
3.0.2
Done
Development

No branches or pull requests

4 participants