Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nima: 'Accept-Encoding' header parse error #6352

Closed
ukarim opened this issue Mar 3, 2023 · 0 comments
Closed

Nima: 'Accept-Encoding' header parse error #6352

ukarim opened this issue Mar 3, 2023 · 0 comments
Assignees
Labels
4.x Version 4.x Níma Helidon Níma
Projects
Milestone

Comments

@ukarim
Copy link

ukarim commented Mar 3, 2023

Environment Details

  • Helidon Version: 4.0.0-ALPHA5
  • Helidon SE

Problem Description

Nima webserver fails to parse Accept-Encoding if header contains list of codings separated by only commas.
For example, this value gzip;q=1.0,deflate;q=0.6,identity;q=0.3 leads to NumberFormatException inside io.helidon.nima.http.encoding.ContentEncodingSupportImpl$EncodingWithQ.parse method.

Current parser uses comma+space as delimiter, but it seems that accoring to rfc that space is optional.
Actually I discovered this issue doing http requests to nima server using ruby's standard http client.

Steps to reproduce

Do following request to Nima webserver

curl -H 'Accept-Encoding: gzip;q=1.0,deflate;q=0.6,identity;q=0.3' http://localhost:8080

@github-actions github-actions bot added this to Triage in Backlog Mar 3, 2023
@spericas spericas self-assigned this Mar 7, 2023
@spericas spericas added 4.x Version 4.x Níma Helidon Níma labels Mar 7, 2023
@spericas spericas moved this from Triage to Normal priority in Backlog Mar 7, 2023
@spericas spericas added this to the 4.0.0 milestone Mar 7, 2023
@spericas spericas closed this as completed Mar 8, 2023
Backlog automation moved this from Normal priority to Closed Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x Níma Helidon Níma
Projects
Backlog
  
Closed
Development

No branches or pull requests

2 participants