Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helidon 0.10.0 build failed in local system #64

Closed
hantsy opened this issue Sep 18, 2018 · 8 comments
Closed

Helidon 0.10.0 build failed in local system #64

hantsy opened this issue Sep 18, 2018 · 8 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@hantsy
Copy link

hantsy commented Sep 18, 2018

Environment Details

  • Helidon Version: 0.10.0
  • Helidon SE or Helidon MP
  • JDK version: java version "1.8.0_181"
  • OS: Windows 10
  • Docker version (if applicable):

Problem Description

The quickstart-se and quickstart-mp modules defined in root pom.xml does not existed.

Steps to Reproduce

  1. Downloaded the source codes archive of 0.10.0 from Release tab
  2. Extracted the files into local disc
  3. Entered the root folder, and ran mvn clean install, and got the following errors:
[ERROR]
[ERROR]   The project io.helidon:helidon-project:0.10.0 (E:\Users\hantsy\temp\helidon-0.10.0\pom.xml) has 2 errors
[ERROR]     Child module E:\Users\hantsy\temp\helidon-0.10.0\quickstart-se of E:\Users\hantsy\temp\helidon-0.10.0\pom.xml does not exist
[ERROR]     Child module E:\Users\hantsy\temp\helidon-0.10.0\quickstart-mp of E:\Users\hantsy\temp\helidon-0.10.0\pom.xml does not exist

@romain-grecourt
Copy link
Contributor

There is an issue with the helidon-tags, these modules are not intended in the reactor.

@barchetta
Copy link
Member

Workaround:

  1. Edit top level pom.xml
  2. Remove these two lines:
    <module>quickstart-se</module>
    <module>quickstart-mp</module>

@barchetta barchetta added the bug Something isn't working label Sep 18, 2018
@romain-grecourt romain-grecourt added this to the 1.0 milestone Sep 18, 2018
@romain-grecourt romain-grecourt added this to To do in Bugs via automation Sep 18, 2018
@romain-grecourt romain-grecourt moved this from To do to In progress in Bugs Sep 18, 2018
@romain-grecourt
Copy link
Contributor

I've manually fixed-up all the tags, @barchetta will take care of fixing the build scripts to make sure this does not happen for future releases.

@barchetta barchetta added this to In progress in Team Board Sep 19, 2018
Bugs automation moved this from In progress to Done Sep 19, 2018
@barchetta barchetta moved this from In progress to Done in Team Board Sep 19, 2018
@hantsy
Copy link
Author

hantsy commented Sep 19, 2018

@barchetta I have tried this way, some tests are failed in my local system. I was using -Dmaven.test.skip=true -DskipTests to build it sucessfully.

Another small issue when I build this project locally.

The JDk toolchian version is not defined by default, I am using ~/.m2/toolchains.xml to use multi jdks.

https://github.com/oracle/helidon/blob/master/pom.xml#L1261-L1992

I have to pass a maven.compiler.target to mvn command to make it work.

@romain-grecourt
Copy link
Contributor

The toolchains profile is incomplete, IIRC @ljnelson had some changes to make it work.
If possible share the failed tests so that we can track that in a specific issue.

@hantsy
Copy link
Author

hantsy commented Sep 20, 2018

@romain-grecourt created #72

@ljnelson
Copy link
Member

Regarding toolchains: the maven.compiler.target property is never set. You can use a toolchain more reliably, I think, by doing, e.g., mvn clean install -DjdkToolchainVersion=8. See also:

https://github.com/oracle/helidon/blob/5972bd9ad0fe5abe645df699f7f35341984ad318/pom.xml#L1268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Bugs
Done
Team Board
  
Done
Development

No branches or pull requests

4 participants