Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Nima WebServer.Builder #6420

Closed
Tomas-Kraus opened this issue Mar 16, 2023 · 1 comment
Closed

Clean up Nima WebServer.Builder #6420

Tomas-Kraus opened this issue Mar 16, 2023 · 1 comment
Assignees
@tomas-langer @Tomas-Kraus
Labels
4.x Version 4.x Níma Helidon Níma webserver
Projects
Backlog

Comments

@Tomas-Kraus
Copy link
Member

Issue #6278 follow up.

Builder initialization:

        private Builder() {
            this(Config.create());
        }

is bad. Config.create() call shall be removed.
And there are more things to be cleaned up in this builder.
@Tomas-Kraus Tomas-Kraus added webserver 4.x Version 4.x Níma Helidon Níma labels Mar 16, 2023
@github-actions github-actions bot added this to Triage in Backlog Mar 16, 2023
@Tomas-Kraus Tomas-Kraus mentioned this issue Mar 16, 2023
Merged
@Tomas-Kraus
Copy link
Member Author

#6419 duplicate, closing

Backlog automation moved this from Triage to Closed Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomas-langer tomas-langer

@Tomas-Kraus Tomas-Kraus

Labels
4.x Version 4.x Níma Helidon Níma webserver
Projects
Backlog
  
Closed
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomas-langer @Tomas-Kraus